Dismiss Notice
Wynncraft, the Minecraft MMORPG. Play it now on your Minecraft client at (IP): play.wynncraft.com. No mods required! Click here for more info...
Dismiss Notice
Have some great ideas for Wynncraft? Join the official CT (content team) and help us make quests, builds, cinematics and much more!

Sell All At [treasure Merchant]

Discussion in 'General Suggestions' started by INTmAker, Nov 2, 2019.

?

Is this good idea?

  1. Yes

    61.5%
  2. No

    38.5%
Thread Status:
Not open for further replies.
  1. INTmAker

    INTmAker Skilled Adventurer

    Messages:
    3
    Likes Received:
    6
    Trophy Points:
    28
    Guild:
    Minecraft:
    Simply add sell all at Treasure Merchant.
     
    YoshisWorld likes this.
  2. Selvut283

    Selvut283 Circadian rhythm stuck on Tokyo time ♪ Music GM CHAMPION

    Messages:
    7,042
    Likes Received:
    21,894
    Trophy Points:
    215
    Creator Karma:
    Guild:
    Minecraft:
    We don't have the ability to add this kind of option; we'd need to add it to all kinds of merchant, as they're a standardized setup.

    Essentially, what you're doing according to the system is you're buying emeralds. The merchant sells emeralds for the price of the different reef treasures, so we'd need to add a "Buy All" button, and that means a "Buy All" button would be added to all shops...imagine accidentally clicking the "Buy All" button on a shop other than the Treasure Merchant! You'd waste all your emeralds!
     
  3. TrapinchO

    TrapinchO retired observer of the wiki VIP+ Featured Wynncraftian

    Messages:
    4,664
    Likes Received:
    6,642
    Trophy Points:
    215
    Minecraft:
    What about adding shift click like at emerald merchants?
     
  4. INTmAker

    INTmAker Skilled Adventurer

    Messages:
    3
    Likes Received:
    6
    Trophy Points:
    28
    Guild:
    Minecraft:
    I am java developer and that is very easy to accomplish.

    Only what we need is SHIFT-LEFT-CLICK for sell all, only in Treasure Merchant, also there is no buy in Treasure Merchant.

    I waste a few minutes for clicking.
     
  5. Druser

    Druser ele defs don't matter HERO Featured Wynncraftian

    Messages:
    5,888
    Likes Received:
    11,477
    Trophy Points:
    215
    Guild:
    Minecraft:
    This is how you get spaghetti code.
     
    RazorGuild and BqwaOLD like this.
  6. TrapinchO

    TrapinchO retired observer of the wiki VIP+ Featured Wynncraftian

    Messages:
    4,664
    Likes Received:
    6,642
    Trophy Points:
    215
    Minecraft:
    spaghetti?
     
    BqwaOLD likes this.
  7. INTmAker

    INTmAker Skilled Adventurer

    Messages:
    3
    Likes Received:
    6
    Trophy Points:
    28
    Guild:
    Minecraft:
    ?
     
  8. BqwaOLD

    BqwaOLD Famous Adventurer

    Messages:
    1,288
    Likes Received:
    2,407
    Trophy Points:
    151
    Minecraft:
    You know. Noodles n sauce *Slurps but the sauce gets in the right angle between the bottom of your nose and your lip*


    What he actually means is that code is all over the place, and unorganized, like an actual bowl of spaghetti, which each noodle being a line of code.
     
    vaughaan likes this.
  9. Selvut283

    Selvut283 Circadian rhythm stuck on Tokyo time ♪ Music GM CHAMPION

    Messages:
    7,042
    Likes Received:
    21,894
    Trophy Points:
    215
    Creator Karma:
    Guild:
    Minecraft:
    I don't think you understand.

    Every single merchant in the game uses a standardized system. If something in one changes, something in all of them change.

    And yes, you're buying everything from a merchant. Even if you're going to an Emerald Merchant, what you're doing is buying an emerald block for 64 emeralds, or a liquified emerald for 64 emerald blocks. It's not stated as buying, but to the system, that's how it is. Adding a shift-click function to buy all would cause a lot of unnecessary pain in other merchants. The way we do it is obviously different from the way you're thinking of it.
     
  10. INTmAker

    INTmAker Skilled Adventurer

    Messages:
    3
    Likes Received:
    6
    Trophy Points:
    28
    Guild:
    Minecraft:
    I don't think you understand. You can always check name of GUI and make sparated code for that. When player clicked SHIFT-LEFT-CLICK on some item in merchant. First we need to get quantity of items by lore or name that the player has in inventory. Based on the name or lore of the item that will be sold, we can set how many bought items per 1 sold item player will receive. We need to check before the process that the player has enough space for these items to receive. If the player has enough space, process of removing the sold items is carried out, then the process of giving the purchased items.

    Also make special listening of SHIFT-LEFT-CLICK for that merchant if you don't want to globalize this my system.

    Than you need to make another system for that merchant. I can make it in 10 minutes because it's so simple....

    Learn Spigot API before posting things like this. Because you obviously don't understand what you're saying.
     
    Last edited: Nov 4, 2019
  11. victorpotato2

    victorpotato2 Broke af HERO

    Messages:
    671
    Likes Received:
    414
    Trophy Points:
    95
    Minecraft:
    Yeet salty spaghettiman!
     
  12. seeksery

    seeksery Wybel Photographer HERO

    Messages:
    639
    Likes Received:
    1,361
    Trophy Points:
    146
    Minecraft:
    iirc, wynn uses its own API, and it's such a jumbled mess that barely anyone can work it
     
  13. INTmAker

    INTmAker Skilled Adventurer

    Messages:
    3
    Likes Received:
    6
    Trophy Points:
    28
    Guild:
    Minecraft:
    Meh it's like Spigot API with another syntax. Because it's based on Minecraft API. So it's same thing, different packaging.
    ________________________________
    Are you okay...?
     
    Last edited: Nov 4, 2019
  14. seeksery

    seeksery Wybel Photographer HERO

    Messages:
    639
    Likes Received:
    1,361
    Trophy Points:
    146
    Minecraft:
    it's not a matter of whether it can be added; that is definitely possible
    the main issue is that the code is so messy that nobody can do it
    the api was in the process of being untangled, but the main (and at the time, only) dev left in the process, which left the code completely broken and unworkable
     
    INTmAker likes this.
  15. INTmAker

    INTmAker Skilled Adventurer

    Messages:
    3
    Likes Received:
    6
    Trophy Points:
    28
    Guild:
    Minecraft:
    Who is that dev?
     
  16. ParkourTNT

    ParkourTNT Wynncraft has houses in the 1.20 update :D HERO

    Messages:
    1,028
    Likes Received:
    1,117
    Trophy Points:
    128
    Minecraft:
    jpresent, he was a developer in Wynncraft but left for RL reasons.
     
  17. NagisaStreams

    NagisaStreams Sertified idiot CHAMPION

    Messages:
    425
    Likes Received:
    1,339
    Trophy Points:
    89
    Guild:
    Minecraft:
    INTmAker I won't bother worrying about if you are the world's best coder in the world as it doesn't matter here. As selvut said twice, and as others pointed out to you, Wynncraft has a way of doing things that (at least for now) is better left unchanged. Not a matter of preference, but more of it just isn't the best idea. No one here is saying like "this idea is bad because it is stupid", its more of "This idea is fine, but implementing it would cause other issues".

    I will put it this way, while you may be correct about 'being very easy to accomplish' it is a matter of what it would cause after. If you say you are a java coder you should really be able to understand, and you should definitely know what spaghetti code is. Checking the name of the GUI sounds like a cool idea and I am not against that, but you likely haven't noticed almost every merchant has a name in the GUI that is shared (at least I believe it is, I haven't checked this). I don't know how wynncraft's code works, but I do know that what you want would require them to make a system completely different from what they have now.

    Basically, somethings are best left unchanged, even if it means not adding a cool feature.
     
    vaughaan and StormKing3 like this.
  18. INTmAker

    INTmAker Skilled Adventurer

    Messages:
    3
    Likes Received:
    6
    Trophy Points:
    28
    Guild:
    Minecraft:
    You are very wrong. If we left things unchanged , all dies with time. Adding small cool things to improve gameplay is important as adding big things. Also why add something if its not tested. And it is not so big project to accomplish.

    If you think that java can't compare 2 strings, than you should not reply. If we have GUI names "Merchant 1" and "Merchant 2". The inventory name is basically a string and we can compare it with some another string like this currentGuiName.equals("Merchant 2"), that will output boolean(true/false). If we want to check if value contains another value we can use currentGuiName.contains("Merchant"). Wynncraft API is Spigot API with another function names.
     
    Last edited: Nov 5, 2019
  19. StormKing3

    StormKing3 Famous Adventurer

    Messages:
    1,816
    Likes Received:
    751
    Trophy Points:
    115
    Guild:
    Minecraft:
    Gosh you are spitting bars, you're almost as argumentative as me!
     
  20. vaughaan

    vaughaan Well-Known Adventurer HERO

    Messages:
    86
    Likes Received:
    31
    Trophy Points:
    49
    Guild:
    Minecraft:
    I think it’s fine the way it is, dern is looking fantastic. Bye

    Edit: this java script dude is sorta yikers
    But wait, he insulted selvut
    Can I get a bippity-ban
     
Thread Status:
Not open for further replies.